Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add @inhibited and @inhibited_by filters #4421

Merged
merged 1 commit into from Jun 22, 2022
Merged

Conversation

prymitive
Copy link
Owner

Fixes #4397

@github-actions
Copy link

Webpack bundle size diff

Total diff: +1.1 KB

M build/static/js/972.e0b44874.chunk.js 21.9 KB 23.1 KB +1.1 KB
M Components/MainModal 10.1 KB 11.2 KB +1.1 KB

@prymitive prymitive force-pushed the inhibited branch 2 times, most recently from d33f819 to ec3d2c4 Compare June 22, 2022 16:44
@github-actions
Copy link

github-actions bot commented Jun 22, 2022

Go benchmark diff

name                               old time/op        new time/op        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           5.50ms ± 3%        5.37ms ± 1%   -2.30%  (p=0.000 n=10+10)
Decompress/Run-2                         7.84ms ±10%        8.88ms ±10%  +13.30%  (p=0.001 n=10+10)
CompressionAndDecompression/Run-2        14.8ms ± 3%        16.5ms ± 3%  +11.48%  (p=0.000 n=10+10)
PullAlerts/0.22.0-2                      5.13ms ± 1%        5.48ms ± 2%   +6.83%  (p=0.000 n=10+10)
AlertsAPIMisses/0.22.0-2                 1.44ms ± 1%        1.51ms ± 2%   +4.85%  (p=0.000 n=10+10)
AlertsAPIMissesAutoGrid/0.22.0-2         1.54ms ± 4%        1.60ms ± 2%   +4.07%  (p=0.000 n=10+10)
AlertsAPIHits/0.22.0-2                    920µs ± 1%         931µs ± 1%   +1.21%  (p=0.000 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                         140µs ± 2%         143µs ± 2%   +1.92%  (p=0.004 n=9+9)
DedupAutocomplete/Run-2                  70.8µs ± 2%        71.8µs ± 4%     ~     (p=0.063 n=10+10)
DedupColors/Run-2                        16.9µs ± 2%        16.8µs ± 2%     ~     (p=0.143 n=10+10)

name                               old %/compression  new %/compression  delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             0.04 ± 0%          0.04 ± 0%     ~     (all equal)

name                               old B/alloc        new B/alloc        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                            3.12M ± 0%         3.12M ± 0%   +0.17%  (p=0.000 n=9+9)
Decompress/Run-2                          1.23M ± 0%         1.24M ± 0%   +0.35%  (p=0.000 n=8+10)
CompressionAndDecompression/Run-2         3.12M ± 0%         3.12M ± 0%   +0.16%  (p=0.000 n=9+9)
PullAlerts/0.22.0-2                       1.18M ± 0%         1.19M ± 0%   +0.45%  (p=0.000 n=9+9)
AlertsAPIMisses/0.22.0-2                  1.70M ± 0%         1.72M ± 0%   +1.10%  (p=0.000 n=9+9)
AlertsAPIMissesAutoGrid/0.22.0-2          1.75M ± 0%         1.77M ± 0%   +1.04%  (p=0.000 n=9+9)
AlertsAPIHits/0.22.0-2                    1.69M ± 0%         1.71M ± 0%   +1.12%  (p=0.000 n=9+9)

name                               old alloc/op       new alloc/op       delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           1.13MB ± 0%        1.13MB ± 0%     ~     (p=0.697 n=10+10)
Decompress/Run-2                         10.6MB ± 0%        10.6MB ± 0%     ~     (p=1.111 n=9+10)
CompressionAndDecompression/Run-2        11.8MB ± 0%        11.8MB ± 0%     ~     (p=0.137 n=10+8)
PullAlerts/0.22.0-2                      1.33MB ± 0%        1.34MB ± 0%   +0.64%  (p=0.000 n=10+10)
AlertsAPIMisses/0.22.0-2                 1.34MB ± 0%        1.34MB ± 0%     ~     (p=0.631 n=10+10)
AlertsAPIMissesAutoGrid/0.22.0-2         1.37MB ± 0%        1.37MB ± 0%   -0.14%  (p=0.035 n=10+9)
AlertsAPIHits/0.22.0-2                    341kB ± 1%         342kB ± 1%     ~     (p=0.171 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                         112kB ± 0%         112kB ± 0%     ~     (p=0.127 n=10+10)
DedupAutocomplete/Run-2                  40.0kB ± 0%        40.1kB ± 0%   +0.24%  (p=0.000 n=9+10)
DedupColors/Run-2                        9.17kB ± 0%        9.17kB ± 0%     ~     (p=1.000 n=10+10)

name                               old allocs/op      new allocs/op      delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             33.0 ± 0%          32.6 ± 2%   -1.21%  (p=0.046 n=8+10)
Decompress/Run-2                           98.0 ± 0%          98.0 ± 0%     ~     (all equal)
CompressionAndDecompression/Run-2           132 ± 0%           132 ± 0%     ~     (all equal)
PullAlerts/0.22.0-2                       22.2k ± 0%         22.4k ± 0%   +0.68%  (p=0.000 n=10+9)
AlertsAPIMisses/0.22.0-2                  7.18k ± 0%         7.18k ± 0%     ~     (all equal)
AlertsAPIMissesAutoGrid/0.22.0-2          7.04k ± 0%         7.04k ± 0%   +0.03%  (p=0.000 n=8+8)
AlertsAPIHits/0.22.0-2                    2.42k ± 0%         2.42k ± 0%     ~     (p=0.059 n=10+8)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                           826 ± 0%           826 ± 0%     ~     (all equal)
DedupAutocomplete/Run-2                     125 ± 0%           127 ± 0%   +1.60%  (p=0.000 n=10+10)
DedupColors/Run-2                          43.0 ± 0%          43.0 ± 0%     ~     (all equal)

@prymitive prymitive merged commit e84bcd7 into main Jun 22, 2022
@prymitive prymitive deleted the inhibited branch June 22, 2022 17:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Ability to hide inhibited alerts
1 participant