Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for retrieving multiple validator statuses #148

Merged

Conversation

michaelhly
Copy link
Contributor

Allow fetching multiple validator statuses from the ValidatorStatus endpoint. Related Issue: prysmaticlabs/prysm#5578.

@michaelhly michaelhly requested a review from 0xKiwi May 2, 2020 17:44
eth/v1alpha1/validator.proto Outdated Show resolved Hide resolved
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One feedback on the name

eth/v1alpha1/validator.proto Outdated Show resolved Hide resolved
@michaelhly michaelhly force-pushed the multiple-validator-statuses branch 4 times, most recently from 3560a90 to ec44bdf Compare May 5, 2020 23:37
@michaelhly michaelhly force-pushed the multiple-validator-statuses branch from be18533 to e5ac634 Compare May 5, 2020 23:50
@michaelhly michaelhly changed the title Update ValidatorStatus endpoint to support multiple validator statuses Support for retrieving multiple validator statuses May 5, 2020
eth/v1alpha1/validator.proto Outdated Show resolved Hide resolved
@rauljordan
Copy link
Contributor

Thinking about this more, agree on the approach of creating the MultipleValidatorStatus endpoint @michaelhly, thanks for this

@michaelhly michaelhly force-pushed the multiple-validator-statuses branch from 1505c30 to 16c89c1 Compare May 11, 2020 16:15
terencechain
terencechain previously approved these changes May 11, 2020
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rauljordan rauljordan merged commit 3444ffb into prysmaticlabs:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants