Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

Support int32 #67

Merged
merged 1 commit into from Aug 14, 2019
Merged

Support int32 #67

merged 1 commit into from Aug 14, 2019

Conversation

rauljordan
Copy link
Contributor

This resolves #66 and adds full support for int32 fields as ssz-able basic types

@rauljordan rauljordan self-assigned this Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #67     +/-   ##
=========================================
+ Coverage   72.48%   72.89%   +0.4%     
=========================================
  Files          11       11             
  Lines        1065     1081     +16     
=========================================
+ Hits          772      788     +16     
  Misses        183      183             
  Partials      110      110
Impacted Files Coverage Δ
types/determine_size.go 80% <100%> (+0.17%) ⬆️
deep_equal.go 60.52% <100%> (+1.06%) ⬆️
types/basic.go 86.11% <100%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c975a4...f782198. Read the comment docs.

@rauljordan rauljordan merged commit cb4e648 into master Aug 14, 2019
@rauljordan rauljordan deleted the support-ints branch August 14, 2019 04:05
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauljordan could you add one more testcase with a struct with a int32 field.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support int32 fields
3 participants