Enable active balance cache (#9567)

* Enable active balance cache

* gofmt

shared/featureconfig/config.go

@@ -205,9 +205,10 @@ func ConfigureBeaconChain(ctx *cli.Context) {
 		logEnabled(correctlyPruneCanonicalAtts)
 		cfg.CorrectlyPruneCanonicalAtts = true
 	}
-	if ctx.Bool(enableActiveBalanceCache.Name) {
-		logEnabled(enableActiveBalanceCache)
-		cfg.EnableActiveBalanceCache = true
+	cfg.EnableActiveBalanceCache = true
+	if ctx.Bool(disableActiveBalanceCache.Name) {
+		logDisabled(disableActiveBalanceCache)
+		cfg.EnableActiveBalanceCache = false
 	}
 	Init(cfg)
 }

shared/featureconfig/deprecated_flags.go

@@ -12,8 +12,15 @@ var (
 		Usage:  deprecatedUsage,
 		Hidden: true,
 	}
+
+	deprecatedEnableActiveBalanceCache = &cli.BoolFlag{
+		Name:   "enable-active-balance-cache",
+		Usage:  deprecatedUsage,
+		Hidden: true,
+	}
 )
 
 var deprecatedFlags = []cli.Flag{
 	exampleDeprecatedFeatureFlag,
+	deprecatedEnableActiveBalanceCache,
 }

shared/featureconfig/flags.go

@@ -131,9 +131,9 @@ var (
 		Usage: "This fixes a bug where any block attestations can get incorrectly pruned. This improves validator profitability and overall network health," +
 			"see issue #9443 for further detail",
 	}
-	enableActiveBalanceCache = &cli.BoolFlag{
-		Name:  "enable-active-balance-cache",
-		Usage: "This enables active balance cache cache to improve node performance during block processing",
+	disableActiveBalanceCache = &cli.BoolFlag{
+		Name:  "disable-active-balance-cache",
+		Usage: "This disables active balance cache, which improves node performance during block processing",
 	}
 )
 
@@ -144,7 +144,6 @@ var devModeFlags = []cli.Flag{
 	forceOptMaxCoverAggregationStategy,
 	correctlyInsertOrphanedAtts,
 	correctlyPruneCanonicalAtts,
-	enableActiveBalanceCache,
 }
 
 // ValidatorFlags contains a list of all the feature flags that apply to the validator client.
@@ -195,7 +194,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
 	enableHistoricalSpaceRepresentation,
 	correctlyInsertOrphanedAtts,
 	correctlyPruneCanonicalAtts,
-	enableActiveBalanceCache,
+	disableActiveBalanceCache,
 }...)
 
 // E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E.