Remove redundant parentheses around nil values (#8199)

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>

beacon-chain/cache/depositcache/deposits_cache_test.go

@@ -611,8 +611,8 @@ func TestPruneProofs_Ok(t *testing.T) {
 
 	require.NoError(t, dc.PruneProofs(context.Background(), 1))
 
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[0].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[1].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[0].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[1].Deposit.Proof)
 	assert.NotNil(t, dc.deposits[2].Deposit.Proof)
 	assert.NotNil(t, dc.deposits[3].Deposit.Proof)
 }
@@ -654,7 +654,7 @@ func TestPruneProofs_SomeAlreadyPruned(t *testing.T) {
 
 	require.NoError(t, dc.PruneProofs(context.Background(), 2))
 
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[2].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[2].Deposit.Proof)
 }
 
 func TestPruneProofs_PruneAllWhenDepositIndexTooBig(t *testing.T) {
@@ -694,10 +694,10 @@ func TestPruneProofs_PruneAllWhenDepositIndexTooBig(t *testing.T) {
 
 	require.NoError(t, dc.PruneProofs(context.Background(), 99))
 
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[0].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[1].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[2].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[3].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[0].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[1].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[2].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[3].Deposit.Proof)
 }
 
 func TestPruneProofs_CorrectlyHandleLastIndex(t *testing.T) {
@@ -737,10 +737,10 @@ func TestPruneProofs_CorrectlyHandleLastIndex(t *testing.T) {
 
 	require.NoError(t, dc.PruneProofs(context.Background(), 4))
 
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[0].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[1].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[2].Deposit.Proof)
-	assert.DeepEqual(t, ([][]byte)(nil), dc.deposits[3].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[0].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[1].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[2].Deposit.Proof)
+	assert.DeepEqual(t, [][]byte(nil), dc.deposits[3].Deposit.Proof)
 }
 
 func makeDepositProof() [][]byte {

beacon-chain/db/kv/deposit_contract_test.go

@@ -15,7 +15,7 @@ func TestStore_DepositContract(t *testing.T) {
 	contractAddress := common.Address{1, 2, 3}
 	retrieved, err := db.DepositContractAddress(ctx)
 	require.NoError(t, err)
-	assert.DeepEqual(t, ([]uint8)(nil), retrieved, "Expected nil contract address")
+	assert.DeepEqual(t, []uint8(nil), retrieved, "Expected nil contract address")
 	require.NoError(t, db.SaveDepositContractAddress(ctx, contractAddress))
 	retrieved, err = db.DepositContractAddress(ctx)
 	require.NoError(t, err)

slasher/db/kv/attester_slashings_test.go

@@ -158,7 +158,7 @@ func TestStore_UpdateAttesterSlashingStatus(t *testing.T) {
 		has, st, err = db.HasAttesterSlashing(ctx, tt.as)
 		require.NoError(t, err, "Failed to get attester slashing")
 		require.Equal(t, true, has, "Failed to find attester slashing: %v", tt.as)
-		require.Equal(t, (types.SlashingStatus)(types.Included), st, "Failed to find attester slashing with the correct status: %v", tt.as)
+		require.Equal(t, types.SlashingStatus(types.Included), st, "Failed to find attester slashing with the correct status: %v", tt.as)
 	}
 }
 

slasher/db/kv/block_header_test.go

@@ -23,7 +23,7 @@ func TestNilDBHistoryBlkHdr(t *testing.T) {
 
 	bPrime, err := db.BlockHeaders(ctx, slot, validatorID)
 	require.NoError(t, err, "Failed to get block")
-	require.DeepEqual(t, ([]*ethpb.SignedBeaconBlockHeader)(nil), bPrime, "Should return nil for a non existent key")
+	require.DeepEqual(t, []*ethpb.SignedBeaconBlockHeader(nil), bPrime, "Should return nil for a non existent key")
 }
 
 func TestSaveHistoryBlkHdr(t *testing.T) {
@@ -90,7 +90,7 @@ func TestDeleteHistoryBlkHdr(t *testing.T) {
 		require.NoError(t, err, "Save block failed")
 		bh, err := db.BlockHeaders(ctx, tt.bh.Header.Slot, tt.bh.Header.ProposerIndex)
 		require.NoError(t, err)
-		assert.DeepEqual(t, ([]*ethpb.SignedBeaconBlockHeader)(nil), bh, "Expected block to have been deleted")
+		assert.DeepEqual(t, []*ethpb.SignedBeaconBlockHeader(nil), bh, "Expected block to have been deleted")
 	}
 }
 

slasher/db/kv/proposer_slashings_test.go

@@ -244,7 +244,7 @@ func TestStore_UpdateProposerSlashingStatus(t *testing.T) {
 		has, st, err = db.HasProposerSlashing(ctx, tt.ps)
 		require.NoError(t, err, "Failed to get proposer slashing")
 		require.Equal(t, true, has, "Failed to find proposer slashing")
-		require.Equal(t, (types.SlashingStatus)(types.Included), st, "Failed to find proposer slashing with the correct status")
+		require.Equal(t, types.SlashingStatus(types.Included), st, "Failed to find proposer slashing with the correct status")
 	}
 }
 

slasher/db/kv/validator_id_pubkey_test.go

@@ -40,7 +40,7 @@ func TestNilDBValidatorPublicKey(t *testing.T) {
 
 	pk, err := db.ValidatorPubKey(ctx, validatorID)
 	require.NoError(t, err, "Nil ValidatorPubKey should not return error")
-	require.DeepEqual(t, ([]uint8)(nil), pk)
+	require.DeepEqual(t, []uint8(nil), pk)
 }
 
 func TestSavePubKey(t *testing.T) {

validator/db/kv/historical_attestations_test.go

@@ -80,7 +80,7 @@ func TestSetTargetData(t *testing.T) {
 			target:      0,
 			source:      100,
 			signingRoot: []byte{1, 2, 3},
-			expected:    (EncHistoryData)(nil),
+			expected:    EncHistoryData(nil),
 			error:       "encapsulated data size",
 		},
 		{