Invert reduce attester state copies (#6185)

* Invert cfg.ReduceAttesterStateCopy flag

* Fix build

shared/featureconfig/config.go

@@ -217,10 +217,6 @@ func ConfigureBeaconChain(ctx *cli.Context) {
 		log.Warn("Disabling state reference copy")
 		cfg.EnableStateRefCopy = false
 	}
-	if ctx.Bool(reduceAttesterStateCopy.Name) {
-		log.Warn("Enabling feature that reduces attester state copy")
-		cfg.ReduceAttesterStateCopy = true
-	}
 	if ctx.IsSet(deprecatedP2PWhitelist.Name) {
 		log.Warnf("--%s is deprecated, please use --%s", deprecatedP2PWhitelist.Name, cmd.P2PAllowList.Name)
 		if err := ctx.Set(cmd.P2PAllowList.Name, ctx.String(deprecatedP2PWhitelist.Name)); err != nil {
@@ -233,7 +229,11 @@ func ConfigureBeaconChain(ctx *cli.Context) {
 			log.WithError(err).Error("Failed to update P2PDenyList flag")
 		}
 	}
-
+	cfg.ReduceAttesterStateCopy = true
+	if ctx.Bool(disableReduceAttesterStateCopy.Name) {
+		log.Warn("Disabling reducing attester state copy")
+		cfg.ReduceAttesterStateCopy = false
+	}
 	Init(cfg)
 }
 

shared/featureconfig/flags.go

@@ -157,17 +157,16 @@ var (
 		Name:  "enable-init-sync-wrr",
 		Usage: "Enables weighted round robin fetching optimization",
 	}
-	reduceAttesterStateCopy = &cli.BoolFlag{
-		Name:  "reduce-attester-state-copy",
-		Usage: "Reduces the amount of state copies for attester rpc",
+	disableReduceAttesterStateCopy = &cli.BoolFlag{
+		Name:  "disable-reduce-attester-state-copy",
+		Usage: "Disables the feature to reduce the amount of state copies for attester rpc",
 	}
 )
 
 // devModeFlags holds list of flags that are set when development mode is on.
 var devModeFlags = []cli.Flag{
 	enableNewStateMgmt,
 	enableInitSyncWeightedRoundRobin,
-	reduceAttesterStateCopy,
 }
 
 // Deprecated flags list.
@@ -400,6 +399,11 @@ var (
 		Usage:  deprecatedUsage,
 		Hidden: true,
 	}
+	deprecateReduceAttesterStateCopies = &cli.BoolFlag{
+		Name:   "reduce-attester-state-copy",
+		Usage:  deprecatedUsage,
+		Hidden: true,
+	}
 )
 
 var deprecatedFlags = []cli.Flag{
@@ -448,6 +452,7 @@ var deprecatedFlags = []cli.Flag{
 	deprecateEnableFieldTrie,
 	deprecatedP2PWhitelist,
 	deprecatedP2PBlacklist,
+	deprecateReduceAttesterStateCopies,
 }
 
 // ValidatorFlags contains a list of all the feature flags that apply to the validator client.
@@ -505,7 +510,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
 	enableInitSyncWeightedRoundRobin,
 	disableFieldTrie,
 	disableStateRefCopy,
-	reduceAttesterStateCopy,
+	disableReduceAttesterStateCopy,
 }...)
 
 // E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E.
@@ -515,5 +520,4 @@ var E2EBeaconChainFlags = []string{
 	"--check-head-state",
 	"--enable-new-state-mgmt",
 	"--enable-init-sync-wrr",
-	"--reduce-attester-state-copy",
 }