Ignore PreGenesis Messages Instead Of Rejecting Them (#7550)

* ignorePreGenesisMessages * fix test + handelaar's review * fix issues * change back Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
prysmaticlabs · Oct 22, 2020 · 7131cd9 · 7131cd9
1 parent 17a08a7
commit 7131cd9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/beacon-chain/sync/subscriber.go b/beacon-chain/sync/subscriber.go
@@ -169,10 +169,10 @@ func (s *Service) wrapAndReportValidation(topic string, v pubsub.ValidatorEx) (s
 			messageFailedValidationCounter.WithLabelValues(topic).Inc()
 			return pubsub.ValidationReject
 		}
-		// Reject any messages received before chainstart.
+		// Ignore any messages received before chainstart.
 		if !s.chainStarted {
 			messageFailedValidationCounter.WithLabelValues(topic).Inc()
-			return pubsub.ValidationReject
+			return pubsub.ValidationIgnore
 		}
 		b := v(ctx, pid, msg)
 		if b == pubsub.ValidationReject {

diff --git a/beacon-chain/sync/subscriber_test.go b/beacon-chain/sync/subscriber_test.go
@@ -280,7 +280,7 @@ func Test_wrapAndReportValidation(t *testing.T) {
 				},
 				chainstarted: false,
 			},
-			want: pubsub.ValidationReject,
+			want: pubsub.ValidationIgnore,
 		},
 		{
 			name: "validator panicked",