Ignore PreGenesis Messages Instead Of Rejecting Them #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7550 +/- ##
==========================================
- Coverage 61.64% 61.62% -0.03%
==========================================
Files 422 422
Lines 29761 29688 -73
==========================================
- Hits 18347 18296 -51
+ Misses 8479 8465 -14
+ Partials 2935 2927 -8 |
prestonvanloon
previously approved these changes
Oct 16, 2020
rauljordan
previously approved these changes
Oct 21, 2020
rauljordan
previously approved these changes
Oct 21, 2020
|
Looks like tests fail. PTAL |
rauljordan
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
Discussed offline with @prestonvanloon , rejecting a message is risky in the context of peer scoring. We instead just
ignore them so as to be on the safe side.
Following from #7494
Which issues(s) does this PR fix?
N.A
Other notes for review