Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some places return an epoch where a sync committee period is expected instead #14206

Closed
rupam-04 opened this issue Jul 11, 2024 · 0 comments · Fixed by #14406
Closed

Some places return an epoch where a sync committee period is expected instead #14206

rupam-04 opened this issue Jul 11, 2024 · 0 comments · Fixed by #14406

Comments

@rupam-04
Copy link
Contributor

rupam-04 commented Jul 11, 2024

💎 Issue

Background

@rkapka pointed out in this PR #14186
#14186 (comment)

Description

I went ahead to see in which other places the helper function compute_sync_committee_period_at_slot from CL specs
has been used as slots.ToEpoch() in the already existing implementations and asked @rkapka if they were correct or not. He said they were incorrect too and we need to wrap them using slots.SyncCommitteePeriod(). One such example would be

updateSignaturePeriod := slots.ToEpoch(block.Block().Slot())

Right now the fix is blocked by #14186 as the latter is working with the same file. Once it gets merged I'll start working on this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant