Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlocksByRoot request type should be [][32]byte #3438

Closed
prestonvanloon opened this issue Sep 10, 2019 · 2 comments
Closed

BlocksByRoot request type should be [][32]byte #3438

prestonvanloon opened this issue Sep 10, 2019 · 2 comments
Assignees
@prestonvanloon
Labels
Priority: High High priority item

Comments

@prestonvanloon
Copy link
Member

The request type is not using a ssz container for BlocksByRoot.

This breaks our design of using proto.Message as the base message so we'll need to rethink the API.

See ethereum/consensus-specs#1404 for the latest incoming changes.
@prestonvanloon prestonvanloon self-assigned this Sep 10, 2019
@prestonvanloon
Copy link
Member Author

There are a few other diffs with networking spec, we'll need to review

@rauljordan
Copy link
Contributor

Resolved by #3512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prestonvanloon prestonvanloon

Labels
Priority: High High priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rauljordan @prestonvanloon