-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join collator pool: check that account is not already in collator pool #39
Projects
Milestone
Comments
the deposit method in SMC checks if account is already in collator pool, the following err catches it
|
We can close this issue. SMC's deposit method checks if the account is in collator pool |
The TODO still exists |
Status on this issue? Can this be closed? @terenc3t @prestonvanloon |
we should close this, I don't see the TODO anymore |
Perfect, feel free to close @terenc3t.
2018年4月23日(月) 10:23 terence tsao <notifications@github.com>:
we should close this, I don't see the TODO anymore
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFUIPQ5fnW4BuYDFfW1WK-2SroBeOmdCks5trg34gaJpZM4SSgiv>
.
--
Sent from Mobile
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See TODO here:
https://github.com/prysmaticlabs/geth-sharding/blob/972509a8c2d3934cb6711e467138ac471b43b344/sharding/vmc.go#L58-L60
The text was updated successfully, but these errors were encountered: