Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join collator pool: check that account is not already in collator pool #39

Closed
prestonvanloon opened this issue Feb 25, 2018 · 6 comments

Comments

@prestonvanloon
Copy link
Member

prestonvanloon commented Feb 25, 2018

See TODO here:
https://github.com/prysmaticlabs/geth-sharding/blob/972509a8c2d3934cb6711e467138ac471b43b344/sharding/vmc.go#L58-L60

@prestonvanloon prestonvanloon added this to the Ruby milestone Feb 25, 2018
@prestonvanloon prestonvanloon added this to To do in Validator Client via automation Feb 25, 2018
@terencechain
Copy link
Member

terencechain commented Feb 27, 2018

the deposit method in SMC checks if account is already in collator pool, the following err catches it

tx, err := c.smc.SMCTransactor.Deposit(txOps)

@rauljordan rauljordan changed the title Join validator set: Check that account is not already in validator set Join collator pool: check that account is not already in collator pool Mar 8, 2018
@terencechain
Copy link
Member

We can close this issue. SMC's deposit method checks if the account is in collator pool

Validator Client automation moved this from To do to Done Mar 24, 2018
Validator Client automation moved this from Done to In progress Mar 24, 2018
@prestonvanloon
Copy link
Member Author

The TODO still exists

@rauljordan
Copy link
Contributor

Status on this issue? Can this be closed? @terenc3t @prestonvanloon

@terencechain
Copy link
Member

we should close this, I don't see the TODO anymore

@rauljordan
Copy link
Contributor

rauljordan commented Apr 23, 2018 via email

Validator Client automation moved this from In progress to Done Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants