Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Archiver Service #5350

Closed
1 of 5 tasks
rauljordan opened this issue Apr 8, 2020 · 7 comments
Closed
1 of 5 tasks

Deprecate Archiver Service #5350

rauljordan opened this issue Apr 8, 2020 · 7 comments
Assignees
Labels
Blocked Blocked by research or external factors Priority: Medium Medium priority item
Milestone

Comments

@rauljordan
Copy link
Contributor

rauljordan commented Apr 8, 2020

Now that we generate states on the fly by using a cool new state management technique piloted by @terencechain, we no longer need the concept of an "archival" node nor the "archiver" service in Prysm. This is a tracking issue to deprecate such service and delete its code from our repo. Blocked until v0.11 is merged in.

Edited by @terencechain 👇

Here's the list of archival RPC end points that need work on:

  • ListValidatorAssignments
  • GetValidatorActiveSetChanges
  • GetValidatorParticipation
  • ListBeaconCommittees
  • StreamIndexedAttestations
@rauljordan rauljordan added Blocked Blocked by research or external factors Priority: Medium Medium priority item new-state-mgmt labels Apr 8, 2020
@terencechain
Copy link
Member

This is mentioned in #4958

Should we just have one canonical tracking? or you prefer a side tracking for deprecation specifically?

@terencechain terencechain self-assigned this Apr 8, 2020
@terencechain
Copy link
Member

Working on ListValidatorAssignments

@rauljordan
Copy link
Contributor Author

Can we close this one @terencechain

@terencechain
Copy link
Member

No, we haven't fully deprecated the archival service yet. DB and service objects still exist

@prestonvanloon
Copy link
Member

Is this still blocked? I think that the new state management was set to default for Onyx (alpha.10+).

@terencechain
Copy link
Member

Blocked by testing. We should let the default mode (alpha 10+) run in the wild for a few weeks before fully deprecating archival service. There's no going back or else we'll just end up reverting work like in Topaz

This was referenced Jun 29, 2020
@rauljordan
Copy link
Contributor Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked by research or external factors Priority: Medium Medium priority item
Projects
None yet
Development

No branches or pull requests

3 participants