Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow States To Be Returned as SSZ Objects #5918

Closed
nisdas opened this issue May 20, 2020 · 4 comments 路 Fixed by #5926
Closed

Allow States To Be Returned as SSZ Objects #5918

nisdas opened this issue May 20, 2020 · 4 comments 路 Fixed by #5926
Labels
API Api related tasks Enhancement New feature or request

Comments

@nisdas
Copy link
Member

nisdas commented May 20, 2020

馃殌 Feature Request

Description

Currently we do not have any easy way to retrieve our states as ssz objects, instead
their json representation is returned with fields encoded in base64.

Describe the solution you'd like

Our debug endpoints instead return the ssz representation of the state. Since
these endpoints are only for debugging runtime problems it would make sense for
them to be ssz encoded.

Describe alternatives you've considered

Manually converting the current format would be cumbersome.

@nisdas nisdas added API Api related tasks Enhancement New feature or request labels May 20, 2020
@terencechain
Copy link
Member

We should do the same for blocks as well

@rauljordan
Copy link
Contributor

@terencechain that would be really hard if we tried to amend our current blocks endpoint to return ssz. You mean adding a new debug endpoint called debug/blocks that returns [][]byte ?

@rauljordan
Copy link
Contributor

Would like to hear if there is a strong use case for it or required for the purposes of debugging

@terencechain
Copy link
Member

For less UX friction, I think it has be a separate end point. Use case is to rerun state transition. Having ssz state is not enough without ssz block to rerun the state transition to debug consensus issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants