Add Debug Block Endpoint + Return SSZ-Encoded #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
API
beacon-chain/rpc/debug/block.go
Outdated
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "Could not retrieve block by root: %v", err) | ||
| } | ||
| encoded, err := ssz.Marshal(signedBlock.Block) |
There was a problem hiding this comment.
don't you want to Marshal the whole thing including signature?
| req *pbrpc.BlockRequest, | ||
| ) (*pbrpc.SSZResponse, error) { | ||
| root := bytesutil.ToBytes32(req.BlockRoot) | ||
| signedBlock, err := ds.BeaconDB.Block(ctx, root) |
Codecov Report
@@ Coverage Diff @@
## master #5926 +/- ##
==========================================
+ Coverage 59.40% 59.61% +0.21%
==========================================
Files 318 319 +1
Lines 26796 26862 +66
==========================================
+ Hits 15917 16015 +98
+ Misses 8720 8686 -34
- Partials 2159 2161 +2 |
terencechain
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds
/eth/v1alpha1/debug/stateand/eth/v1alpha1/debug/blockto return an ssz-encoded response. It also allows the ability to get a beacon block by its root.Which issues(s) does this PR fix?
Fixes #5918