Invert enable-state-field-trie flag #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6013 +/- ##
==========================================
+ Coverage 59.57% 59.61% +0.04%
==========================================
Files 320 320
Lines 26970 26946 -24
==========================================
- Hits 16067 16065 -2
+ Misses 8713 8701 -12
+ Partials 2190 2180 -10 |
rauljordan
previously approved these changes
May 27, 2020
|
In the future, I can recommend just renaming the flag? Releasing a flag should be just a few changes under featureconfig package, all of these changes are a potential risk that has to be reviewed carefully. |
|
Example: #5931 |
prestonvanloon
requested changes
May 27, 2020
terencechain
changed the title
terencechain
force-pushed
the
invert-flag2
branch
from
783f82d
to
5ed5318
Compare
terencechain
force-pushed
the
invert-flag2
branch
from
5ed5318
to
8d21c29
Compare
prestonvanloon
previously approved these changes
May 27, 2020
|
Small conflict @terencechain |
rauljordan
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and merge #6012 first
As part of alpha9 todo, this PR inverts enable-state-field-trie flag. This flag has been running in exp pods and on external validators many weeks without any issue