New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert enable-state-field-trie flag #6013
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6013 +/- ##
==========================================
+ Coverage 59.57% 59.61% +0.04%
==========================================
Files 320 320
Lines 26970 26946 -24
==========================================
- Hits 16067 16065 -2
+ Misses 8713 8701 -12
+ Partials 2190 2180 -10 |
In the future, I can recommend just renaming the flag? Releasing a flag should be just a few changes under featureconfig package, all of these changes are a potential risk that has to be reviewed carefully. |
Example: #5931 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I just saw this doesn’t fit the normal release protocol. It’s suppose to be:
- opt-in
- opt-out
- flag removal and deprecated code clean up
783f82d
to
5ed5318
Compare
5ed5318
to
8d21c29
Compare
Small conflict @terencechain |
Review and merge #6012 first
As part of alpha9 todo, this PR inverts enable-state-field-trie flag. This flag has been running in exp pods and on external validators many weeks without any issue