Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save unaggregated att in beacon_aggregate_and_proof subscriber #6109

Merged
merged 9 commits into from Jun 3, 2020
Merged

Save unaggregated att in beacon_aggregate_and_proof subscriber #6109

merged 9 commits into from Jun 3, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Jun 3, 2020 •
edited

What type of PR is this?

Bug fix

[2020-06-03 11:41:36] ERROR sync: Failed to handle p2p pubsub error=attestation is not aggregated
github.com/prysmaticlabs/prysm/beacon-chain/operations/attestations/kv.(*AttCaches).SaveAggregatedAttestation
	beacon-chain/operations/attestations/kv/aggregated.go:74

What does this PR do? Why is it needed?
Unaggregated attestation can be valid in beacon_aggregate_and_proof subnet. This PR ensures that it's properly handled and saved.

Which issues(s) does this PR fix?

Fixes #5649

@terencechain terencechain added the Ready For Review A pull request ready for code review label Jun 3, 2020
@terencechain terencechain requested a review from a team as a code owner June 3, 2020 18:43
@terencechain terencechain self-assigned this Jun 3, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit c4afb8e into master Jun 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-save-agg branch June 3, 2020 19:49
@rauljordan rauljordan mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR sync: Failed to handle p2p pubsub error=attestation is not aggregated
2 participants
@terencechain @rauljordan