Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregator to send unaggregated attestation #6110

Closed
terencechain opened this issue Jun 3, 2020 · 3 comments · Fixed by #6137
Closed

Fix aggregator to send unaggregated attestation #6110

terencechain opened this issue Jun 3, 2020 · 3 comments · Fixed by #6137
Assignees
@terencechain
Labels
Bug Something isn't working Priority: High High priority item

Comments

@terencechain
Copy link
Member

terencechain commented Jun 3, 2020 •
edited

Prysm has an incorrect assumption that only aggregated attestation can flow in beacon_aggregate_and_proof subnet. This assumption has blocked attester from submitting its own unaggregated attestation or aggregator from submitting unaggregated attestation in v0.12. Validators will lose money because of this

level=error msg="Could not submit slot signature to beacon node: rpc error: code = Internal desc = No aggregated attestation in beacon node" prefix=validator slot=5612
@terencechain terencechain self-assigned this Jun 3, 2020
@terencechain terencechain added Bug Something isn't working Priority: High High priority item labels Jun 3, 2020
@rauljordan
Copy link
Contributor

Resolved by #6109

@terencechain
Copy link
Member Author

terencechain commented Jun 4, 2020 •
edited

Ah. Not resolved #6109. That fixes the receiver side.
We'll still need to fix the sender side. I'll address this tomorrow

@terencechain terencechain reopened this Jun 4, 2020
@rauljordan
Copy link
Contributor

Got it, sorry @terencechain didn't see the associated issue before closing this. Title could have a been a bit more descriptive as it felt like a duplicate of an old issue

@terencechain terencechain changed the title Could not submit slot signature to beacon node, No aggregated attestation in beacon node Fix aggregator to send unaggregated attestation Jun 4, 2020
@terencechain terencechain mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terencechain terencechain

Labels
Bug Something isn't working Priority: High High priority item
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix aggregator with unaggregated attestation prysmaticlabs/prysm
2 participants
@rauljordan @terencechain