Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregator with unaggregated attestation #6137

Merged
merged 11 commits into from
Jun 5, 2020

Conversation

terencechain
Copy link
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?
Previously an aggregator will ignore unaggregated attestation. As we have learned this is not a desired behavior. In poor network condition, it's possible an unaggregated attestation exists in subnet and an aggregator will still have to send that out

Which issues(s) does this PR fix?

Fixes #6110

@terencechain terencechain requested a review from a team as a code owner June 4, 2020 21:48
@terencechain terencechain self-assigned this Jun 4, 2020
@terencechain terencechain added the Ready For Review A pull request ready for code review label Jun 4, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit d349404 into master Jun 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-aggregator-broadcast branch June 5, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix aggregator to send unaggregated attestation
2 participants