Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ferran's Generated SSZ Instead of Generic SSZ, Remove Bazel Passthrough #6116

Closed
rauljordan opened this issue Jun 3, 2020 · 2 comments 路 Fixed by #6135
Closed

Use Ferran's Generated SSZ Instead of Generic SSZ, Remove Bazel Passthrough #6116

rauljordan opened this issue Jun 3, 2020 · 2 comments 路 Fixed by #6135
Labels
Enhancement New feature or request Priority: High High priority item
Milestone

Comments

@rauljordan
Copy link
Contributor

馃拵 Issue

Background

Currently, everywhere we do ssz.Marshal or Unmarshal, bazel applies a runtime patch to use ferran's fast ssz for whitelisted structs instead. This is a security hole when running with the normal Go tool. Instead, we should actually use ferran's fast ssz instead of go-ssz when we need to.

@rauljordan rauljordan added Enhancement New feature or request Priority: High High priority item labels Jun 3, 2020
@protolambda
Copy link

Removing go-ssz is important, as I believe compositeSliceSSZ in go-ssz doesn't check list limits. Making it susceptible to a network split if used in production in a multi-client testnet. And there have been others problems, as discussed in discord. And with a new better SSZ, I am all for replacing the bazel build step to just default prysm to a safe and fast ssz, in every build mode. 馃憦

@prestonvanloon prestonvanloon added this to the Diamond milestone Jun 4, 2020
@prestonvanloon
Copy link
Member

I think this is related: #5981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Priority: High High priority item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants