Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Max SSZ Size Checks on Raw P2P Request/Response Data #5981

Closed
rauljordan opened this issue May 25, 2020 · 1 comment
Closed

Enforce Max SSZ Size Checks on Raw P2P Request/Response Data #5981

rauljordan opened this issue May 25, 2020 · 1 comment
Labels
Priority: Low Low priority item
Milestone

Comments

@rauljordan
Copy link
Contributor

💎 Issue

Background

Part of #5935, there is now a recommendation to enforce max size SSZ bounds for data received via p2p. Although this is not required for the testnet restart, we would need to look into this before mainnet or include this before the coordinated multiclient launch.

A resolution for this issue would be to precompute the max possible sizes of items such as blocks and check the raw byte size received via p2p in order to reject requests or responses.

@rauljordan
Copy link
Contributor Author

Done by #6147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low priority item
Projects
None yet
Development

No branches or pull requests

1 participant