Use FastSSZ Everywhere Applicable #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Jun 4, 2020
rauljordan
commented
Jun 4, 2020
rauljordan
commented
Jun 4, 2020
rauljordan
commented
Jun 4, 2020
rauljordan
commented
Jun 4, 2020
rauljordan
commented
Jun 4, 2020
rauljordan
commented
Jun 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #6135 +/- ##
==========================================
- Coverage 59.80% 59.76% -0.05%
==========================================
Files 323 323
Lines 27386 27379 -7
==========================================
- Hits 16378 16362 -16
- Misses 8789 8798 +9
Partials 2219 2219 |
terencechain
approved these changes
Jun 5, 2020
prestonvanloon
approved these changes
Jun 5, 2020
rauljordan
added
OK to merge
Ready For Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Currently, we utilize a git patch applied at Bazel runtime to change all instances of ssz.Marshal and Unmarshal to utilize ferranbt's Fast SSZ. This is a huge security hole for people running Prysm with pure Go. This PR favors usage of fastssz everywhere and removes the patch used by Bazel.
Which issues(s) does this PR fix?
Fixes #6116