New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init-sync queue assert order and uniqueness of blocks emitted #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6146 +/- ##
=======================================
Coverage 59.92% 59.92%
=======================================
Files 323 323
Lines 27443 27443
=======================================
Hits 16446 16446
Misses 8769 8769
Partials 2228 2228 |
…bs/prysm into init-sync-queue-dedup-blocks
farazdagi
added
OK to merge
Ready For Review
A pull request ready for code review
and removed
In Progress
labels
Jun 8, 2020
rauljordan
approved these changes
Jun 8, 2020
terencechain
approved these changes
Jun 8, 2020
prestonvanloon
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #5857
Other notes for review
init-sync
process: peers can provide wrong data, slot ranges need to be re-requested, and processing redone. Therefore, extra caution must be applied when filtering out blocks.processBlock
function didn't end up in error, block can be considered as processed, and its slot is logged. All future requests toprocessBlock
must be made for a higher slots.This problem will not occur with filtering at the round robin level - as on restart, slot's after the head slot will be re-checked again.