Check Whether Block Is Already Processed #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5850 +/- ##
==========================================
- Coverage 60.31% 59.96% -0.35%
==========================================
Files 312 312
Lines 27158 26207 -951
==========================================
- Hits 16379 15714 -665
+ Misses 8605 8353 -252
+ Partials 2174 2140 -34 |
terencechain
approved these changes
May 14, 2020
terencechain
added a commit
that referenced
this pull request
May 14, 2020
This reverts commit 7630f18.
michaelhly
pushed a commit
to michaelhly/prysm
that referenced
this pull request
May 14, 2020
* check for missing blocks * error log * add test * fix lint * fix test * terence's review * do not mess with on block * Merge refs/heads/master into addCheck
michaelhly
pushed a commit
to michaelhly/prysm
that referenced
this pull request
May 14, 2020
* Revert "Check Whether Block Is Already Processed (prysmaticlabs#5850)" This reverts commit 7630f18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Code Improvement
What does this PR do? Why is it needed?
We process all blocks that we receive in sync whether we have processed them before or not. This caused issues in schlesi, when other clients returned duplicate blocks to us. Due to certain optimizations we have made in sync, processing the same block twice, leads us to regenerating the prestate, which is expensive.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A