Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert reduce attester state copies #6185

Merged
merged 2 commits into from Jun 9, 2020
Merged

Conversation

terencechain
Copy link
Member

This PR inverts ReduceAttesterStateCopy feature flag. This flag has been running great in exp pods for the last 10 days. Exp pods's memories are 500MB less than prod pods

@terencechain terencechain added Enhancement New feature or request Ready For Review A pull request ready for code review labels Jun 9, 2020
@terencechain terencechain requested a review from a team as a code owner June 9, 2020 16:09
@terencechain terencechain self-assigned this Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #6185 into master will increase coverage by 0.27%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #6185      +/-   ##
==========================================
+ Coverage   59.59%   59.87%   +0.27%     
==========================================
  Files         341      323      -18     
  Lines       29777    27516    -2261     
==========================================
- Hits        17747    16474    -1273     
+ Misses       9587     8813     -774     
+ Partials     2443     2229     -214     

@rauljordan rauljordan merged commit 568d8c7 into master Jun 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the invert-reduce-state-copies branch June 9, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants