-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Peers Properly With Connection Gater #6251
Conversation
} | ||
} | ||
|
||
func TestPeerAllowList(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be good to add test that allow address to peer
Codecov Report
@@ Coverage Diff @@
## master #6251 +/- ##
==========================================
- Coverage 60.07% 59.90% -0.18%
==========================================
Files 323 325 +2
Lines 27422 27469 +47
==========================================
- Hits 16473 16454 -19
- Misses 8733 8772 +39
- Partials 2216 2243 +27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
* add new filtering * add new tests * gaz * shay's review * Merge branch 'master' into fixFiltering
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
We add filtering to our connection gater so that we can appropriately handle allow and deny lists
properly in its context. Also we now fix allow lists so that only ip's which satisfy the cidr mask are allowed to connect to the beacon node.
Which issues(s) does this PR fix?
Follows on from #6243
Other notes for review