Filter Peers Properly With Connection Gater #6251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayzluf
reviewed
Jun 14, 2020
| } | ||
| } | ||
|
|
||
| func TestPeerAllowList(t *testing.T) { |
There was a problem hiding this comment.
it will be good to add test that allow address to peer
Codecov Report
@@ Coverage Diff @@
## master #6251 +/- ##
==========================================
- Coverage 60.07% 59.90% -0.18%
==========================================
Files 323 325 +2
Lines 27422 27469 +47
==========================================
- Hits 16473 16454 -19
- Misses 8733 8772 +39
- Partials 2216 2243 +27 |
lee51525125
pushed a commit
to lee51525125/prysm
that referenced
this pull request
Jun 15, 2020
* add new filtering * add new tests * gaz * shay's review * Merge branch 'master' into fixFiltering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
We add filtering to our connection gater so that we can appropriately handle allow and deny lists
properly in its context. Also we now fix allow lists so that only ip's which satisfy the cidr mask are allowed to connect to the beacon node.
Which issues(s) does this PR fix?
Follows on from #6243
Other notes for review