Refactor params/config to separate files for clarity #6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Enhancement
rauljordan
previously approved these changes
Jun 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #6427 +/- ##
==========================================
- Coverage 61.47% 60.83% -0.65%
==========================================
Files 350 355 +5
Lines 29061 29123 +62
==========================================
- Hits 17866 17717 -149
- Misses 8806 9030 +224
+ Partials 2389 2376 -13 |
terencechain
previously approved these changes
Jun 26, 2020
terencechain
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
As we get closer to mainnet and we support multiple testnets, the config.go file will continue to grow in size.
This PR splits up the monolithic file into individual files which are in the format of
testnet_X_config.go. This way, readers should be able to quickly find network configuration for a particular network. Additionally, this makes adding or removing testnet support simplier as all of the relevant config code for the particular network is in a single file.Which issues(s) does this PR fix?
Part of #6342
Other notes for review
I'll resolve conflicts in #6414 as well.