Align to spec v1.0.0 #7469
Align to spec v1.0.0 #7469
Conversation
terencechain
force-pushed
the
v1.0.0-rc.0
branch
from
378cc84
to
c769565
Compare
terencechain
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
terencechain
removed
the
Stale
Codecov Report
@@ Coverage Diff @@
## master #7469 +/- ##
==========================================
+ Coverage 62.03% 62.07% +0.04%
==========================================
Files 430 431 +1
Lines 30475 30451 -24
==========================================
- Hits 18905 18903 -2
+ Misses 8628 8603 -25
- Partials 2942 2945 +3 |
* Add Pyrmont config * Fix config * Update genesis time to the correct value
terencechain
changed the title
| @@ -16,19 +16,6 @@ import ( | |||
|
|
|||
| var runAmount = 25 | |||
|
|
|||
| func TestExecuteStateTransition_FullBlock(t *testing.T) { | |||
There was a problem hiding this comment.
I'm removing this test. This is actually more housekeeping work than good. Whenever there's a change to a beacon object, this test requires a manual update
terencechain
added
Ready For Review
| SlotsPerHistoricalRoot: 8192, | ||
| MinValidatorWithdrawabilityDelay: 256, | ||
| ShardCommitteePeriod: 256, | ||
| MinEpochsToInactivityPenalty: 4, | ||
| Eth1FollowDistance: 1024, | ||
| Eth1FollowDistance: 2048, | ||
| SafeSlotsToUpdateJustified: 8, | ||
| SecondsPerETH1Block: 13, |
There was a problem hiding this comment.
This doesn't match spec. https://github.com/ethereum/eth2.0-specs/blob/579da6d2dc734b269dbf67aa1004b54bb9449784/configs/mainnet/phase0.yaml#L48.
In reality, eth1 block times are 13 seconds on average and Prysm's eth1 connection sends too many requests this value is wrong. Thanks to @nisdas for investigating. Discord discussion link
There was a problem hiding this comment.
I've asked @nisdas to file an issue so we can outline our spec config deviation and potentially have the spec correct this value.
There was a problem hiding this comment.
It's also worth noting that current master has been at 13s, This v1.0.0 branch did not make this particular change.
With that said, this was the only field that did not align with latest config
https://github.com/prysmaticlabs/prysm/blob/master/shared/params/mainnet_config.go#L85
There was a problem hiding this comment.
| SlotsPerHistoricalRoot: 8192, | ||
| MinValidatorWithdrawabilityDelay: 256, | ||
| ShardCommitteePeriod: 256, | ||
| MinEpochsToInactivityPenalty: 4, | ||
| Eth1FollowDistance: 1024, | ||
| Eth1FollowDistance: 2048, | ||
| SafeSlotsToUpdateJustified: 8, | ||
| SecondsPerETH1Block: 13, |
There was a problem hiding this comment.
I've asked @nisdas to file an issue so we can outline our spec config deviation and potentially have the spec correct this value.
What goes in here?
Items that are not backwards compatible with current
masterandmedallatestnetNotable components that should be there
BLSv4Disv5Change list: