Add Pyrmont config #7797
Merged
Add Pyrmont config #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
rauljordan,
rkapka and
nisdas
and removed request for
a team
prestonvanloon
approved these changes
Nov 12, 2020
prestonvanloon
requested changes
Nov 12, 2020
There was a problem hiding this comment.
Genesis time is supposed to be 1605700800.
https://github.com/protolambda/pyrmont/blob/54d7f9f563b8d89c8bfc70cb62f9032ba6bc2880/config.yaml#L20
|
My bad, I messed up the readme and left the old toledo genesis time in there. The config is correct |
|
Does Prysm check the chain ID / network ID that the eth1 RPC supports? Maybe a good feature to warn the user if they are still on goerli, while they should soon be on mainnet! |
We do check. It's here: |
prestonvanloon
approved these changes
Nov 12, 2020
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Nov 13, 2020
* Update eth1data params to double * Update spec tests tags and state field for fssz gen * Update more spec test sha tags * Update slashing params * Update slashing precompute to use config instead of hardcoded 3 * Update slashing test values due to config changes * Update configs for slashedless test * Go mod tidy * Add toledo config (#7743) * Update genesis delay to one week (#7782) * Add Pyrmont config (#7797) * Add Pyrmont config * Fix config * Update genesis time to the correct value * Remove TestExecuteStateTransition_FullBlock * Add back missing comments * Update spectests to v1.0.0 Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Pyrmont config
https://github.com/protolambda/pyrmont