Check Chainstart Before Processing Messages In Pubsub #7494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -277,6 +277,11 @@ func (s *Service) registerHandlers() { | |||
| } | |||
| } | |||
|
|
|||
| // marks the chain as having started. | |||
| func (s *Service) markForChainStart() { | |||
There was a problem hiding this comment.
Suggested change
| func (s *Service) markForChainStart() { | |
| func (s *Service) setChainStart() { |
Sounds better?
| @@ -277,6 +277,11 @@ func (s *Service) registerHandlers() { | |||
| } | |||
| } | |||
|
|
|||
| // marks the chain as having started. | |||
| func (s *Service) markForChainStart() { | |||
| s.chainStarted = true | |||
There was a problem hiding this comment.
Do we want to add a lock ?
There was a problem hiding this comment.
This method can only be called once and that too from a single routine. I don't think a lock is necessary here
|
This PR mostly does a defensive check during genesis to make sure that we dont receive any messages before chainstart. It's different from #7496, which does a specific subscription check for each topic. @prestonvanloon |
rauljordan
approved these changes
Oct 14, 2020
| // Reject any messages received before chainstart. | ||
| if !s.chainStarted { | ||
| messageFailedValidationCounter.WithLabelValues(topic).Inc() | ||
| return pubsub.ValidationReject |
There was a problem hiding this comment.
I think this is not a good choice. ValidationReject affects peer scoring, we should use ValidationIgnore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Addition
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review