Add gitcop and similar restrictions as go-ethereum

[prestonvanloon]

We're already facing a huge problem with go-ethereum coding guidelines

Please make sure your contributions adhere to our coding guidelines:

Code must adhere to the official Go formatting guidelines (i.e. uses gofmt).
Code must be documented adhering to the official Go commentary guidelines.
Pull requests need to be based on and opened against the master branch.
Commit messages should be prefixed with the package(s) they modify.
E.g. "eth, rpc: make trace configs optional"

We'll need to retroactively conform to these guidelines as well, and it likely won't be very fun, but this should be done sooner rather than later.

[rauljordan]

The only thing we haven't really been following is the commit message structure. Let's make sure everyone on the team is on the same page.

[terencechain]

Web3.py and py-evm's commit message structure:

• What was wrong?
• TODO
• How was it fixed?
• Cute Animal Picture

[terencechain]

Vyper's commit message structure:

• What I did
• How I did it
• How to verify it
• Description for the changelog
• Cute Animal Picture

[terencechain]

Solidity doesn't have a commit message structure, it refers to issue

[terencechain]

Casper's commit message structure:

• Issue
• Proposed implementation

[prestonvanloon]

I reached out to the folks at ethereum/go-ethereum to get a copy of their gitcop configuration. I've also enabled gitcop (I think), but it might not be the same rules until I hear back.

I'll rebase all of our commit messages, but it will take a me a little while to do it since there are 3 months worth of messages that do not conform to the rule.

From now on, we must use the sharding: prefix to our commit messages.

[terencechain]

Let me know if you need help on rebasing our commit msgs

On Sun, Apr 1, 2018 at 5:05 PM Preston Van Loon ***@***.***> wrote: I reached out to the folks at ethereum/go-ethereum to get a copy of their gitcop configuration. I've also enabled gitcop (I think), but it might not be the same rules until I hear back. I'll rebase all of our commit messages, but it will take a me a little while to do it since there are 3 months worth of messages that do not conform to the rule. From now on, we must use the sharding: prefix to our commit messages. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#84 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUVDud2tYDWnfQ_GD83tvPglKRPSDg8-ks5tkWs9gaJpZM4TBwTr> .

-- Terence

[prestonvanloon]

Yeah, any clue how to do this properly? I tried git rebase -i bc76d3e96886cd2e354605bec40d326477090015 and changed the commit messages in the git-todo along with setting it to "reword", but it seems to have not reworded anything and just double signed all commits. master...prestonvanloon:forced-rebase

[rauljordan]

What do we need to get this closed? Do we just have to update all our previous commit msgs?

[prestonvanloon]

Yeah and enable gitcop. I have the settings from Peter in an email. If you know of an easy way to update all of the previous messages, let me know!

[rauljordan]

We will no longer be dependent on Geth. Closing.