Do not use proto casing in v1alpha1 API JSON fields
#8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8988 +/- ##
===========================================
- Coverage 60.93% 60.77% -0.17%
===========================================
Files 531 531
Lines 37541 37814 +273
===========================================
+ Hits 22876 22981 +105
- Misses 11382 11545 +163
- Partials 3283 3288 +5 |
nisdas
approved these changes
Jun 4, 2021
|
This fixes prysmaticlabs/prysm-web-ui#181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
#8697 introduced a breaking change to
v1alpha1APIs. JSON output was modified fromcamelCasetosnake_case, thus breaking the Web UI.Which issues(s) does this PR fix?
Hotfix
Other notes for review
N/A