Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gogoproto compiler to protoc-gen-go-cast #8697

Merged
merged 128 commits into from May 17, 2021
Merged

Change gogoproto compiler to protoc-gen-go-cast #8697

merged 128 commits into from May 17, 2021

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Apr 2, 2021 •
edited

What type of PR is this?
This PR replaces all gogoproto compilers with our own native protobuf v2 compiler. We now support optional fields no longer rely on gogoproto for ethereumapis.

What does this PR do? Why is it needed?
This PR unblocks #7510 to continue implementation of previously blocked endpoints/features.

More context on changes made here: https://hackmd.io/wO5rzfVWS3GrS-L7FNXKGg

Majority of changes are:

  • BUILD.bazel dependency changes
  • Import changes from ptypes.Empty to emptypb.Empty

Please pay attention to changes I've commented on!

@0xKiwi 0xKiwi requested a review from a team as a code owner April 2, 2021 01:57
nisdas
nisdas reviewed May 15, 2021
View reviewed changes
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, will run it for a while on my end to make sure there are no other surprises

nisdas
nisdas previously approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan added OK to merge Ready For Review A pull request ready for code review labels May 17, 2021
@prylabs-bulldozer prylabs-bulldozer bot merged commit 2f10b1c into develop May 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the change-to-gocast branch May 17, 2021 18:32
@rkapka rkapka mentioned this pull request May 24, 2021
Merged
@rkapka rkapka mentioned this pull request Jun 4, 2021
Merged
@prestonvanloon prestonvanloon mentioned this pull request Aug 1, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon left review comments

@terencechain terencechain terencechain left review comments

@rauljordan rauljordan rauljordan approved these changes

@nisdas nisdas nisdas left review comments

@farazdagi farazdagi Awaiting requested review from farazdagi

@rkapka rkapka Awaiting requested review from rkapka

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@0xKiwi @rauljordan @prestonvanloon @terencechain @nisdas @rkapka