Protobuf Changes for Eth2 APIs EventSource Support #8999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8999 +/- ##
===========================================
+ Coverage 60.56% 60.96% +0.39%
===========================================
Files 531 531
Lines 37959 37536 -423
===========================================
- Hits 22990 22883 -107
+ Misses 11694 11367 -327
- Partials 3275 3286 +11 |
terencechain
approved these changes
Jun 7, 2021
0xKiwi
reviewed
Jun 7, 2021
| // | ||
| // This service is defined in the upstream eth2.0-apis repository (eth2.0-APIs/apis/debug). | ||
| service Events { | ||
| // StreamEvents -- |
There was a problem hiding this comment.
Maybe outline this comment more whenever possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Part of the initiative to align with the eth2 standard API, we need to support the events streaming endpoints explained here. We need to support the following schema:
https://ethereum.github.io/eth2.0-APIs/#/Events/eventstream
This PR only contains protobuf changes.