Retrieve validators through v1 API in e2e #9117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested review from
jmozah,
prestonvanloon and
terencechain
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9117 +/- ##
===========================================
+ Coverage 60.22% 60.29% +0.07%
===========================================
Files 544 544
Lines 38755 38755
===========================================
+ Hits 23339 23368 +29
+ Misses 12053 12026 -27
+ Partials 3363 3361 -2 |
rauljordan
approved these changes
Jun 29, 2021
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Tests
What does this PR do? Why is it needed?
Performs two Ethereum API requests using https://ethereum.github.io/eth2.0-APIs/#/Beacon/getStateValidators to assess that our main API components work correctly. These calls pass through the API Middleware, grpc-gateway and the gRPC beacon chain server.
I chose this particular request because it is fairly complicated. It requires base64-hex translations, has query params and enums. All in all it servers as a good API conformance test.