Use correct pre state to call new payload #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Mar 24, 2022
|
|
||
| sigSet.Join(set) | ||
| } | ||
| verify, err := sigSet.Verify() |
There was a problem hiding this comment.
What happens if the signature does not verify, don't we end up with a bad block in forkchoice anyway?
terencechain
added
Ready For Review
…m into use-correct-pre-state
potuz
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the correct pre-state to call a new payload. Revert the refactor from #10398 but still
insertBlockToForkChoiceStorebeforenotifyNewPayloadEDIT:
Based on comment #10416 (comment)
I implemented
notifyNewPayloadto take in post state'sversionandheaderinstead ofpost_stateversion_and_headersto be used to notify new payload after signature validationIsExecutionEnabledUsingHeaderwhich deprecatesExecutionEnabled. The formal does not require input beacon state