Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate Active Balance Cache Feature #10550

Merged
merged 6 commits into from
Apr 21, 2022
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 19, 2022

What type of PR is this?

Feature Graduation

What does this PR do? Why is it needed?

This makes our active balance cache the permanent default in prysm and removes the ability to disable it.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review Cleanup Code health! labels Apr 19, 2022
@nisdas nisdas requested a review from a team as a code owner April 19, 2022 08:32
rkapka
rkapka previously approved these changes Apr 20, 2022
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, radek's approval went stale after merging develop.

@prylabs-bulldozer prylabs-bulldozer bot merged commit d7a7fa0 into develop Apr 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the gradActiveBalCache branch April 21, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants