Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for blst modern builds on linux amd64 #10567

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Add support for blst modern builds on linux amd64 #10567

merged 3 commits into from
Apr 28, 2022

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

Only apply the flag -D__BLST_PORTABLE__ when --define=blst_modern=true is not present.

Which issues(s) does this PR fix?

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner April 26, 2022 14:58
@prestonvanloon prestonvanloon added OK to merge Ready For Review A pull request ready for code review labels Apr 26, 2022
potuz
potuz approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good if someone that knows Bazel reads as well. My understanding of this PR is that it adds a new config blst_modern which when present will not include the BLST_PORTABLE flag. That's all that it's required

@prestonvanloon
Copy link
Member Author

LGTM. It would be good if someone that knows Bazel reads as well. My understanding of this PR is that it adds a new config blst_modern which when present will not include the BLST_PORTABLE flag. That's all that it's required

This is the intention of the change, yes. Thanks!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 314ef8e into develop Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the blst_modern branch April 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz potuz approved these changes

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prestonvanloon @potuz @rkapka