remove equivocating votes from forkchoice #10597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
May 2, 2022
| defer f.votesLock.RUnlock() | ||
|
|
||
| if index > types.ValidatorIndex(len(f.balances)) { | ||
| return |
There was a problem hiding this comment.
I wonder if these plain returns should really be error returns
There was a problem hiding this comment.
There's no need for an error, these could be for example a new validator who's first transaction is a slashable offense. In this case we would honestly not have these balances in forkchoice.
terencechain
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the necessary changes and helper functions on forkchoice to implement ethereum/consensus-specs#2845
It does not prune slashed indices (in the worst case scenario of 1/3 of the entire network being slashed it's about 1GB in memory and we have bigger problems).
It does not implement blockchain package changes, it's contained to forkchoice.