Better re-org log #11253
Merged
Better re-org log #11253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
terencechain
commented
Aug 18, 2022
Comment on lines
+105
to
+106
| log.WithError(err).Error("Could not find common ancestor root") | ||
| commonRoot = params.BeaconConfig().ZeroHash |
There was a problem hiding this comment.
Common ancestor root is only used for logging below, I think we can be more forgiving, if it fails just log it and assign root to zeros. Don't need to fail the entire process block routine
rauljordan
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current log could use more color. I propose we add