Deprecate ttd override flags #11457
Closed
Deprecate ttd override flags #11457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
deprecate-ttd-override-flags
branch
from
f64ef56
to
b75be93
Compare
terencechain
force-pushed
the
deprecate-ttd-override-flags
branch
from
b75be93
to
80def33
Compare
|
Did you plan to deprecate the flags as well? This just made them no-ops, but didn't remove from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
post-merge clean up
What does this PR do? Why is it needed?
Deprecate TTD and blockhash override flags. We do not delete flags because it's a breaking change. This is a post-merge clean-up since these flags will no longer be relevant as we already have merged.
Which issues(s) does this PR fix?
N/A
Other notes for review
N/A