New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prysm V4: Remove Prysm Remote Signer #11895
Conversation
Unless it's completely distinctional and dangerous to use, can we wait on this one a few weeks to see if someone voices over? |
@potuz yes we can wait, this depends on web3signer tls as well. would be good for v4 though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. One question I have is how early we should be warning users about this type of breaking change. Typically we should give them at least a release or more advanced time to prepare. That it goes from deprecate warning -> fully delete
unlike the webui i don't think anyone is currently using this, as it hasn't been updated since before the merge and we only offered a prototype implementation. so I think coinbase was the last user of this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with this is v4 is the next release. Otherwise, we might want to make sure to deprecate instead of deleting
What type of PR is this?
Remove Remote Signer
What does this PR do? Why is it needed?
Prysm Remote Signer hasn't been supported well since last year before the merge. All client teams have since switched to supporting the web3signer interface. This PR attempts to fully remove the Prysm Remote Signer which is gRPC based from the repo clearing up some logic required in the setup.
Depends on #11857
Part of #11841
Which issues(s) does this PR fix?
Fixes #11700