Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Peer Scorer Permanent Default #12138

Merged
merged 3 commits into from Mar 16, 2023
Merged

Make Peer Scorer Permanent Default #12138

merged 3 commits into from Mar 16, 2023

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Mar 16, 2023

What type of PR is this?

Feature Upgrade

What does this PR do? Why is it needed?

  • This PR makes our peer scorer a permanent default and deprecates the ability to disable it along with removing all the affected code.

Which issues(s) does this PR fix?

Part of #11841

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review V4 V4 release related items labels Mar 16, 2023
@nisdas nisdas requested a review from a team as a code owner March 16, 2023 07:04
saolyn
saolyn approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nisdas nisdas merged commit 4d28d69 into develop Mar 16, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the makeScorerPermanentDefault branch March 16, 2023 10:52
prestonvanloon added a commit that referenced this pull request May 11, 2023
@prestonvanloon
Revert "Make Peer Scorer Permanent Default (#12138)"
bc78502 
This reverts commit 4d28d69.
@prestonvanloon prestonvanloon mentioned this pull request May 11, 2023
Merged
prylabs-bulldozer bot pushed a commit that referenced this pull request May 23, 2023
@prestonvanloon
Restore disable-peer-scorer flag (#12386)
cfa64ae 
* Revert "Make Peer Scorer Permanent Default (#12138)"

This reverts commit 4d28d69.

* make peer scoring flag warning scary
james-prysm pushed a commit that referenced this pull request May 23, 2023
@prestonvanloon @james-prysm
Restore disable-peer-scorer flag (#12386)
ed992d9 
* Revert "Make Peer Scorer Permanent Default (#12138)"

This reverts commit 4d28d69.

* make peer scoring flag warning scary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review V4 V4 release related items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nisdas @saolyn