Fully Deprecate Vectorized HTR Flag #12148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
|
DeepSource complains should be simple to fix |
potuz
previously approved these changes
Mar 17, 2023
| @@ -590,11 +592,14 @@ func TestGetSyncCommitteeDuties(t *testing.T) { | |||
| currCommittee := ðpbalpha.SyncCommittee{} | |||
| for i := 5; i < 10; i++ { | |||
| currCommittee.Pubkeys = append(currCommittee.Pubkeys, vals[i].PublicKey) | |||
| currCommittee.AggregatePubkey = make([]byte, 48) | |||
There was a problem hiding this comment.
sanity check: is this because the test was using old logic?
potuz
previously approved these changes
Mar 17, 2023
saolyn
approved these changes
Mar 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Cleanup
What does this PR do? Why is it needed?
This fully deprecates the non-vectorized path for out state hashing routines and makes it the permanent default. The disable flag is added to the deprecated list and all old methods are now removed.
Which issues(s) does this PR fix?
N.A
Other notes for review