Add locks to forkchoice spec tests #12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Mar 20, 2023
| @@ -144,9 +157,9 @@ func (bb *Builder) Check(t testing.TB, c *Check) { | |||
| } | |||
| if c.ProposerBoostRoot != nil { | |||
| want := fmt.Sprintf("%#x", common.FromHex(*c.ProposerBoostRoot)) | |||
| bb.service.ForkChoiceStore().RLock() | |||
There was a problem hiding this comment.
Why is there a ForkChoiceStore and ForkChoicer?
There was a problem hiding this comment.
You can remove one, they are exactly the same method defined in the same file. I do not know from where they are. We should in fact try to remove them both and only export locked wrappers to forkchoice
potuz
requested changes
Mar 20, 2023
terencechain
commented
Mar 21, 2023
potuz
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fix test flakeyness
What does this PR do? Why is it needed?
Add locking to fork choice spec tests to reduce test flakiness and isolate production bugs with flakiness