Isolate forkchoice to blockchain package #12174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
changed the title
potuz
force-pushed
the
remove-forchoicer
branch
from
a10b8bd
to
0b8f53e
Compare
nisdas
reviewed
Mar 21, 2023
| @@ -484,3 +482,66 @@ func (s *Service) Ancestor(ctx context.Context, root []byte, slot primitives.Slo | |||
| func (s *Service) SetGenesisTime(t time.Time) { | |||
| s.genesisTime = t | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think all these methods specific to forkchoice should be in their own file ex: forkchoice_chain_info or something of that sort
terencechain
previously approved these changes
Mar 21, 2023
terencechain
previously approved these changes
Mar 22, 2023
nisdas
reviewed
Mar 22, 2023
| ) | ||
|
|
||
| // SetGenesisTime sets the genesis time of beacon chain. | ||
| func (s *Service) SetGenesisTime(t time.Time) { |
There was a problem hiding this comment.
Is this really a forkchoice method ? Seems unrelated
nisdas
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates forkchoice to the blockchain package, this way consumers do not need to worry about locks.
In particular, it removes the function
ForkChoicer()that exposed explicitly forkchoice to external packages.The blockchain package exposes an interface
blockchain.ForkchoiceFetcherthat wraps all externally used forkchoice functions in a self-locked manner. External callers do not have access to forkchoice directly, but rather have to call blockchain package to lock forkchoice..