Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deadlock between monitor service and init-sync #12427

Merged
merged 2 commits into from May 18, 2023

Conversation

kasey
Copy link
Contributor

@kasey kasey commented May 18, 2023

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?

Fixing an initialization deadlock between the initial sync service and the validator monitor service.

Which issues(s) does this PR fix?

Fixes #12411

@kasey kasey requested a review from a team as a code owner May 18, 2023 18:02
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasey kasey added Ready For Review A pull request ready for code review OK to merge labels May 18, 2023
@prylabs-bulldozer prylabs-bulldozer bot merged commit aeaa72f into develop May 18, 2023
16 checks passed
@prylabs-bulldozer prylabs-bulldozer bot deleted the fix-monitor-initsync-deadlock branch May 18, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of monitor-indices at v4.0.4 cannot sync beacon chain in goerli network
2 participants