Use forkchoice to validate sync messages faster #12430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
May 19, 2023
| // Sync committee verification performance. | ||
| syncMessagesForUnkownBlocks = promauto.NewCounter( | ||
| prometheus.CounterOpts{ | ||
| Name: "sync_committee_messages_unnkown_root", |
There was a problem hiding this comment.
typo here: It should be sync_committee_messages_unknown_root
prestonvanloon
added a commit
that referenced
this pull request
May 22, 2023
prestonvanloon
added a commit
that referenced
this pull request
May 22, 2023
james-prysm
pushed a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches the blockroot of the votes for fast access and uses forkchoice to check that it matches the headroot (that is also cached in the blockchain package)