Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: payload attribute v3 return nil #12736

Merged
merged 1 commit into from Aug 14, 2023
Merged

fix: payload attribute v3 return nil #12736

merged 1 commit into from Aug 14, 2023

Conversation

terencechain
Copy link
Member

To follow engine API spec and like V1 and V2, in the event where payload attribute v3 is empty or fields containing zero values, it should return nil/null instead of an empty struct. This is part of the engine API definition

@terencechain terencechain added Ready For Review A pull request ready for code review Deneb PRs or issues for the Deneb upgrade labels Aug 14, 2023
@terencechain terencechain self-assigned this Aug 14, 2023
@terencechain terencechain requested a review from a team as a code owner August 14, 2023 15:11
@terencechain terencechain requested review from potuz, rkapka and james-prysm and removed request for a team August 14, 2023 15:11
@terencechain terencechain merged commit ff6513c into deneb-integration Aug 14, 2023
14 of 16 checks passed
@terencechain terencechain deleted the payload-attri-v3 branch August 14, 2023 16:46
terencechain added a commit that referenced this pull request Aug 16, 2023
@terencechain
Fix: payload attribute v3 return nil (#12736)
bb5318e
kasey pushed a commit that referenced this pull request Aug 21, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
f9dca46
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
8299f09
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
862f1c6
kasey pushed a commit that referenced this pull request Aug 22, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
52b77d4
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
23082b9
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
b3c6ed8
kasey pushed a commit that referenced this pull request Aug 23, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
58972f3
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
c9641a2
kasey pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @kasey
Fix: payload attribute v3 return nil (#12736)
c6c7cd8
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
7181676
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
4b89205
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
57d1aeb
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
00d3f5b
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
2aaa2f1
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
2ffc80e
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
2a9e082
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
90cf504
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
a94003e
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
3c91d4d
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
47ebb59
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
6e95f23
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
865f1c4
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@terencechain @prestonvanloon
Fix: payload attribute v3 return nil (#12736)
83aaf04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Deneb PRs or issues for the Deneb upgrade Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terencechain @james-prysm